From: Jasper St. Pierre Date: Tue, 22 Apr 2014 03:34:11 +0000 (-0400) Subject: search: Make sure to destroy old provider displays when we unregister X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2532 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=a83b9ed6d784a77c2772d32a591b44a11cf60822;p=gnome-shell.git search: Make sure to destroy old provider displays when we unregister When we unregistered providers, like when we refreshed the list of active remote providers, we would forget to destroy the old provider display after the fact. This left an empty "skeleton" provider display still in the search results that would never be filled in. Make sure to destroy it properly. https://bugzilla.gnome.org/show_bug.cgi?id=728597 --- diff --git a/js/ui/search.js b/js/ui/search.js index 919642a9a..3797b7421 100644 --- a/js/ui/search.js +++ b/js/ui/search.js @@ -68,6 +68,9 @@ const SearchSystem = new Lang.Class({ _unregisterProvider: function (provider) { let index = this._providers.indexOf(provider); this._providers.splice(index, 1); + + if (provider.display) + provider.display.destroy(); }, getProviders: function() {